Rethrow exception, avoiding lose stacktrace

serilog-contrib / Serilog.Enrichers.Sensitive

A Serilog LogEvent enricher that masks sensitive data

MIT License

111 stars 23 forks source link

Rethrow exception, avoiding lose stacktrace #4

Closed AlbertoMonteiro closed 3 years ago

sandermvanvliet commented 3 years ago

Hi @AlbertoMonteiro, Thanks for your PR!

You have actually pointed out something weird altogether as those try/catches aren't really very useful except when trying to debug things and there are better ways to handle this than Debugger.Break().

So what I'm going to do is remove those from the code directly.

sandermvanvliet commented 3 years ago

I've removed the try/catches as part of e048800723698b0b7e5fb99528ca6b770fff75f3 If it's ok with you I'll close the PR.

AlbertoMonteiro commented 3 years ago

@sandermvanvliet go ahead!! Thanks for replying!