search

serilog-contrib / SerilogSinksInMemory

In-memory sink for Serilog to use for testing
MIT License
53 stars 7 forks source link

Remove extraneous semicolon #20

Closed mderriey closed 3 years ago

mderriey commented 3 years ago

Also standardise to 4-space indentation, which I'm happy to undo if you want to keep the PR focused to a single thing 🙏

mderriey commented 3 years ago

Another thing I noticed is the README states:

To verify if a message is logged multiple times use AppearsTimes(int numberOfTimes)

However, all the examples use the Appearing().Times(int numberOfTimes). I'm not sure whether both APIs are available, or if it's an old API that has now been removed.

sandermvanvliet commented 3 years ago

Hi @mderriey! Thanks for this 👍 Always great to get some documentation improvements.

I've had a look but indeed AppearsTimes is very old and has been gone for quite some time. Completely missed it that it was still in the README. If you want to change that to Appearing().Times(...) that would be awesome, otherwise I can do it too.

mderriey commented 3 years ago

Hey @sandermvanvliet 👋

No problem at all, I just pushed another commit to update AppearsTimes() to Appearing().Times().

Cheers 🙏

mderriey commented 3 years ago

Feel free to squash and update the commit message when merging now that it's not just about the semicolon 😉

sandermvanvliet commented 3 years ago

Cool 👍 Thanks a bunch!