search

serilog-contrib / serilog-sinks-applicationinsights

A Serilog sink that writes events to Microsoft Azure Application Insights
Apache License 2.0
220 stars 71 forks source link

switch to using connection string #194

Closed zyofeng closed 2 years ago

nblumhardt commented 2 years ago

Seems like this is as good as we can do; merging with some README updates added :+1:

This will be a breaking change in v4. See https://docs.microsoft.com/en-us/azure/azure-monitor/app/migrate-from-instrumentation-keys-to-connection-strings for migration.

nblumhardt commented 2 years ago

Hmm - I used the command-line instructions to merge, but GitHub hasn't picked it up, for some reason. Seems to have tagged you as the author, however:

https://github.com/serilog-contrib/serilog-sinks-applicationinsights/commit/575b344a610610079276ab10974b3f1e0c31154e

The commit is now on dev. Thanks for the PR!