Closed TsengSR closed 1 year ago
Hi @TsengSR,
Thanks for your opinion. Sounds reasonable, will think about it.
Also plan to drop "standard" from v9+ and set the explicit targets
Extracted to more global #171
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.
Which version of Serilog.Sinks.Grafana.Loki are you using?
v8.1.0
Which version of .NET are you using?
net5.0
Describe the bug
Does the Sink really needs a dependency on
System.Text.Json
7.0.0? For libraries it's generally favored to take the lowest versions which support the required features.Referencing
Serilog.Sinks.Grafana.Loki
in anet5.0
(and probably also innet6.0
gives some nasty and annoying warningseven though it also targets
netstandard2.0
.To Reproduce
Add
Serilog.Sinks.Grafana.Loki
to an emptynet5.0
project.Expected behavior
Adding the Sink should not raise warnings.
Log/SelfLog output or exception with stacktrace
No response
Application or code sample, which could be used to reproduce a bug
No response
Additional context
No response
I have read the documentation