search

serilog-contrib / serilog-sinks-grafana-loki

A Serilog sink sending log events to Grafana Loki
MIT License
201 stars 30 forks source link

Tenant header added #194

Closed mgalczynski closed 1 year ago

mgalczynski commented 1 year ago

Added tenant headed to handle multi-tenancy setup - https://grafana.com/docs/loki/latest/operations/multi-tenancy/

mishamyte commented 1 year ago

Hi @mgalczynski,

Thank you for the PR. Could I ask you to fix the warnings, related to XML-doc?

Also I'm wondering about the rules for the value of that header: Tenant IDs can be any alphanumeric string that fits within the Go HTTP header limit (1MB)

Should we do that alphanumeric validation?

mgalczynski commented 1 year ago

Hi @mishamyte Thank you very much for reviewing my PR quickly. I have fixed XML and added tenant ID validation.

mishamyte commented 1 year ago

Thank you for fix, let me review it one more time and I will release new beta-version for testing with that feature