serilog-contrib / serilog-sinks-grafana-loki

A Serilog sink sending log events to Grafana Loki
MIT License
201 stars 30 forks source link

Version 8.1.0 sends no label to loki #204

Closed CrosRoad95 closed 1 year ago

CrosRoad95 commented 1 year ago

Which version of Serilog.Sinks.Grafana.Loki are you using?

v8.1.0

Which version of .NET are you using?

net8.0

Describe the bug

Created most basic serilog logger with this exported and i noticed no logs being send to the loki. When i downgraded to 7.1.1 it worked. But if i had letf version 8.1.0 it partially worked when i provide labels in "GrafanaLoki" method example "level" value for "propertiesAsLabel" manually, but then logs doesn't format properly in loki, i see template instead of rendered message.

Looked even into code to find maybe some flag like "treat all properties as labels"

To Reproduce

just use newest version 8.1.0, it won't work as expected. If you use custom http client you will see "400" bad request

Expected behavior

Version 8.1.0 should by default export all labels

Log/SelfLog output or exception with stacktrace

No response

Application or code sample, which could be used to reproduce a bug

No response

Additional context

No response

I have read the documentation

mishamyte commented 1 year ago

Hi @CrosRoad95!

Could you please confirm that you have read v8 breaking changes and explanation behind them?

If yes, please, provide the configuration part for your logger.

Thanks!

mishamyte commented 1 year ago

Looked even into code to find maybe some flag like "treat all properties as labels"

That flag will not exist, because it's the wrong way of using Loki (check pls best practices) and will lead to the high cardinality problem.

I would suggest check the Using LokiJsonTextFormatter and Grafana Loki json parser article

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.