Public assemblies should have a strong name

[tom-englert]

Which version of Serilog.Sinks.Grafana.Loki are you using?

8.1

Which version of .NET are you using?

net48

Describe the bug

It's not possible to use the sink with a NetFramework project that has a strong name

To Reproduce

Try to use the sink in a NetFramework project with a strong name:

At compile time:

CSC : warning CS8002: Referenced assembly 'Serilog.Sinks.Grafana.Loki, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

At runtime:

System.IO.FileLoadException
Could not load file or assembly 'Serilog.Sinks.Grafana.Loki, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)

Expected behavior

We can compile and run NetFramework projects with a strong name, using this sink.

Log/SelfLog output or exception with stacktrace

System.IO.FileLoadException Could not load file or assembly 'Serilog.Sinks.Grafana.Loki, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)

Application or code sample, which could be used to reproduce a bug

No response

Additional context

No response

I have read the documentation

• [X] I have read Common Problems section in project wiki

[mishamyte]

Hi!

Implemented in v8.2.0-beta.3. Could you pls validate it?

Plan to release v8.2.0 on Monday if all would be good

[mishamyte]

Released as a part of v8.2.0

[tom-englert]

8.2.0 works as expected 👍

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.