Open mishamyte opened 12 months ago
I would like to take a look at the issue. @mishamyte it is assigned to you. I hope you don't mind.
Hey @px-mpavlovsky!
Yeah, no problems. If you have an idea how it could be added to v8 without changing the minimum Serilog's version, I would be happy to see the request from you.
Is there any progress on this? Would be really nice.
Still in backlog 😞
The Serilog's release v3.1.0 brings us the new breaking change:
In the current implementation we have a minimal version of
Serilog
-2.12.0
, in which those properties were not present. So in the next place the are dropped out during the creation of the newLogEvent
https://github.com/serilog-contrib/serilog-sinks-grafana-loki/blob/1bbf8370dc311d6114daad9f7306005b4d0edb90/src/Serilog.Sinks.Grafana.Loki/Models/LokiLogEvent.cs#L49-L59
After the investigation, the decision was taken. As v9 (WIP) will reference
v3.1.0
as a minimal, we will work with those properties from the beginning. As v8 would reach the end of the life after the v9 release, that version would not work with those properties.Originally found in:
Discussed in https://github.com/serilog-contrib/serilog-sinks-grafana-loki/discussions/232