serilog-contrib / serilog-sinks-grafana-loki

A Serilog sink sending log events to Grafana Loki
MIT License
201 stars 30 forks source link

Redesign concept of mapping to labels #98

Closed mishamyte closed 2 years ago

mishamyte commented 2 years ago

Now concept of filters is unusable in 3/4 cases

And as it is told in https://github.com/serilog-contrib/serilog-sinks-grafana-loki/issues/81#issuecomment-1026919565:

  1. Can you imagine any case when filtrationMode = null will be a desired behaviour? I doubt it and right now this is a default value. Because filtration implies some performance impact I would make this entire feature to be optional. Would be great to say "I do not need automatic labeling at all."
mishamyte commented 2 years ago

Concept implemented in early versions of v8:

I.E. global label: Some: 42 Log.Information("{Some}", "word")

Result: Some: 42