Closed MirzaMerdovic closed 7 years ago
Sorry for late response. Change looks good - will take some time this or next week. Thanks
No problem. Thank you.
Cosmetic fixes and removed a test. Though I would like to put some time into it, this one wasn't testing much - thanks though.
all changes in Serilog.Sinks.Slack.1.0.20
Thank you.
The current version is not working with latest Serilog, I think because PeriodicBatchingSink is now in different library: Serilog.Sinks.PeriodicBatching, so I updated the references.
Also I removed RestSharp dependency and used HttpClient which required Newtonsoft.Json, which made the number of dependencies the same regarding external stuff, but Newtonsoft.Json is much more common one, and in my case RestSharp was something that was used only here.
I did some small refactoring also.
I hope this makes sense to you, if not thank you for the sink anyway :)