search

serilog-contrib / serilog-sinks-slack

A simple (yet customizable) Slack logging sink for Serilog
MIT License
41 stars 27 forks source link

Added support for message formatting and fixed a bug #17

Closed zaha closed 7 years ago

zaha commented 7 years ago

Hi @mgibas,

I added support for the outputTemplate/message formatting. While doing so, I stumbled over a little bug that prevented the short format from being used for the attachments. I also added new options to allow the usage of the short format via config flag.

Furthermore, I added the possibility to have the log context properties being added as attachments as well. Really like it that way =)

Hope you find the time to merge this and publish the new version in a timely manner. Want to use this for some of our web services via the NuGet package :)

Cheers Michael

mgibas commented 7 years ago

I will try to take care of that this week - thanks for PR

mgibas commented 7 years ago

Does it break any existing interfaces (compatibility with previous version)?

zaha commented 7 years ago

It shouldn't, I added new overloads for the creation of the sink and defaults for the existing factory method. All new properties also have defaults.

mgibas commented 7 years ago

LGTM then :)