Add a new Timestamp Format option

serilog-contrib / serilog-sinks-slack

A simple (yet customizable) Slack logging sink for Serilog

MIT License

40 stars 28 forks source link

Add a new Timestamp Format option #27

Closed kimsey0 closed 3 years ago

kimsey0 commented 3 years ago

Fixes #25

kimsey0 commented 3 years ago

@TrapperHell, how does this look? 🙂

TrapperHell commented 3 years ago

This is looking good now @kimsey0 . Has it perchance been tested at all, since I currently cannot test this?

kimsey0 commented 3 years ago

I have now, using the sample app, and it seems to work as expected. Here are posted messages with the roundtrip ("o"), short ("d") and default (null) date format, respectively: Slack messages with different date formats (All from my Danish-locale computer.)

TrapperHell commented 3 years ago

Looks good to me. Thank you for your contribution! Just one last thing - if I may - bump up the .csproj version to 2.0.2 so that we can have your build out on nuget.

kimsey0 commented 3 years ago

For sure - done!

Thank you for taking over maintenance on this project and for handling my pull request so quickly. 😄

mgibas commented 3 years ago

@kimsey0 I feel attacked! jk - also happy that this project is alive 😄 🎉

kimsey0 commented 3 years ago

@mgibas: Sorry, I must have misunderstood this https://github.com/mgibas/serilog-sinks-slack/pull/24#issuecomment-753907188. 😜