search

serilog-contrib / serilog-sinks-slack

A simple (yet customizable) Slack logging sink for Serilog
MIT License
41 stars 27 forks source link

Downgraded to .NET 4.5 #4

Closed APErebus closed 7 years ago

APErebus commented 7 years ago

.NET 4.5 is the minimum supported version for Serilog

mgibas commented 7 years ago

What's the purpose of this downgrade ?

APErebus commented 7 years ago

Serilog supports .NET 4.5, but this sink doesn't.

I figured it made sense to have the same minimum supported version

phnx47 commented 7 years ago

It https://github.com/mgibas/serilog-sinks-slack/pull/5 will solve your problem

mgibas commented 7 years ago

Will take a look into it this weekend (#5 as well)

phnx47 commented 7 years ago

I couldn't wait and had already published my fork:

https://github.com/Auditorius/Au.Serilog.Sinks.Slack https://www.nuget.org/packages/Au.Serilog.Sinks.Slack/

And I plan to optimize code

mgibas commented 7 years ago

Thanks to @phnx47 and PR #5 we managed to deploy nugget targeting 4.5, 4.6 and Core1.3 👏 Closing this PR - let me know if you are missing something.