serilog-contrib / serilog-sinks-slackclient

Slack Sink for Serilog
Apache License 2.0
27 stars 15 forks source link

Updating Newtonsoft to Latest #27

Closed mattrhoden closed 2 years ago

mattrhoden commented 2 years ago

Hi,

I didn't see any PR guidelines in this repository, so please let me know if you need any additional information or work. I would like to restrict this PR to just updating Newtonsoft if possible.

Background We are doing some security related updates to our dependencies and would like to get this project updated too. Since there's not much that's automated I did my best to fully get this working in both versions before upgrading but was unable to get .Net Framework project to successfully post to slack.

Steps

  1. Pull down the project and get it building. (Never worked with FSharp, had to run this on a VM because Mono and dotnet core were not playing nice on my mac.)
  2. Get the project to build. The oldest version of dotnet core sdk I had installed was 3.x. After installing 2.0.x I had to update the FSharp targets in order to get the build to pass. Let me know if you need that change set to get the build working locally for you too.
  3. Verify the project works. Two things:
    1. Unfortunately I could not get the .Net Framework 4 version to work. This included both the webhook and app configurations using your samples. I verified my tokens were right by using raw requests with postman first just to be extra sure.
    2. I also had to disable older versions of TLS, I kept getting an error regarding SSL.
  4. Update the package ✅
  5. Verify it still works the same as before ✅

If you're willing to drop support for .Net 4 I would be up for putting together another PR to get this on the latest version of dotnet core and getting the app configuration working because it looks like slack is dropping support for webhooks.

Thanks, Matt

mattrhoden commented 2 years ago

Hi, @marcio-azevedo are you able to take a look at my PR? Thanks!

marcio-azevedo commented 2 years ago

Sorry for the late reply. Approved.