search

serilog-contrib / serilog-sinks-slackclient

Slack Sink for Serilog
Apache License 2.0
27 stars 15 forks source link

NuGet Dependency on OctoPack #7

Closed kimpenhaus closed 7 years ago

kimpenhaus commented 7 years ago

Hi Marcio,

I've recently installed the beta version of your Serilog.Sinks.Slack and was wondering why there is a dependency on OctoPack 3.5.2 when I do install the NuGet package.

As far as I can see, this is just for internal purpose during build / deployment. Is it possible for you to drop this dependency during NuGet package generation?

Thanks and cheers, Marcus

marcio-azevedo commented 7 years ago

Hi Marcus,

You're right, it shouldn't since the Serilog.Sinks.Slack.Core.nuspec doesn't reference that package as dependency. Probably something related with the CI process. I'll check and try to fix it. Thanks for your input.

Regards, Márcio

marcio-azevedo commented 7 years ago

Ok, it's fixed, I'll close this issue.

Thanks for the feedback.

kimpenhaus commented 7 years ago

awesome - thanks!