search

serilog-contrib / serilog-sinks-slackclient

Slack Sink for Serilog
Apache License 2.0
27 stars 15 forks source link

Configuring sink using JSON #8

Closed FantasticFiasco closed 6 years ago

FantasticFiasco commented 7 years ago

Hi!

There is a proposal over at Serilog.Settings.Configuration where sink developers would be able to specify an extension point specially designed to support JSON configuration. If this is something you would find beneficial for your sink, please give a thumbs up or something. If not, have a nice day and continue being awesome!

FantasticFiasco commented 7 years ago

Closing it due to lack of interest.

marcio-azevedo commented 7 years ago

Hi, thanks for the feedback. Let me take a look in the next days and I'll get back to you. Meanwhile I'll re-open this.

FantasticFiasco commented 7 years ago

Sorry, you shouldn't read it as lack of interest from you. The proposal seems to solve a problem no other sink developer experience, thus it will never be implemented in Serilog.Settings.Configuration. That is the reason as to why I closed the issue.

Have a nice day!

marcio-azevedo commented 7 years ago

Not at all! :) All suggestions to improve are welcome! And Pull Requests too! :)

marcio-azevedo commented 6 years ago

Closing this, feel free to re-open, or open a new one if there's more news regarding https://github.com/serilog/serilog-settings-configuration/issues/53.