search

serilog-contrib / serilog-sinks-splunk

A Serilog sink that writes to Splunk
https://splunk.com
Apache License 2.0
46 stars 47 forks source link

Adding Condition=" '$(OS)' != 'Windows_NT' " to PublicSign attribute #112

Closed BrettJaner closed 5 years ago

BrettJaner commented 5 years ago

Adding Condition=" '$(OS)' != 'Windows_NT' " to PublicSign attribute in Serilog.Sinks.Splunk.csproj to solve issue #76. When the PublicSign attribute is removed, the assembly is fully and properly signed. Conditionally applying this attribute based on OS aligns with what the Serilog core library and other sinks are doing.

BrettJaner commented 5 years ago

Just realized the build runs on an Ubuntu image, so you'd think the <PublicSign> would be applied. I checked the Serilog core library and it also builds on Ubuntu image. Now I'm puzzled how this would work.

merbla commented 5 years ago

@BrettJaner the builds run on Linux only for testing. The package pushed to NuGet comes from the Windows build.

Lets try this PR and check the dev packages.

BrettJaner commented 5 years ago

Good deal, checked the package "v3.2.0-dev-00252" and it looks good! Probably should have incremented the minor version number with the pull request.

merbla commented 5 years ago

Bumped the version in #113