search

serilog-contrib / serilog-sinks-splunk

A Serilog sink that writes to Splunk
https://splunk.com
Apache License 2.0
46 stars 47 forks source link

Update to serilog periodic batching 4.x #168

Closed jpfifer closed 8 months ago

jpfifer commented 8 months ago

Updated Serilog and Serilog Periodic Batcher Dependencies to current version

The contract for serilog-periodic-batcher changed from a base class approach to a composition approach which requires changing the EventCollectorSink to support the new interface. With the upgrade the target framework was matched to the target framework used by serilog-periodic-batcher.

Updated the target framework for the unit tests to match the target framework used by serilog-periodic-batcher

Additionally updated the tests, and sample Docker/compose. I've not been able to get it to run correctly, but it fails under the current dev version as well (at least on Fedora Linux 39)

VictorioBerra commented 8 months ago

@jpfifer Thanks for this PR, I am working to get access as a co-maintainer to this project, and then I can start reviewing and getting some of these PRs moving. Would you mind to re-visit this and give it another look?

Regarding the tests, what issues are you having?

merbla commented 8 months ago

@VictorioBerra you should have access now LMK.

VictorioBerra commented 8 months ago

@merbla Looks good, thank you!

EEParker commented 8 months ago

This looks good, based on some of my own branches I think #166 should be merged in first, and this rebased afterward. There are a few more changes I've have pending for dotnet 8.0 here, but I think both of these can be merged in first.

jpfifer commented 8 months ago

Thanks for the help