search

serilog-contrib / serilog-sinks-splunk

A Serilog sink that writes to Splunk
https://splunk.com
Apache License 2.0
46 stars 47 forks source link

Rewrite EventCollectorSink to use composition instead of inheritance,… #170

Closed vvdb-architecture closed 6 months ago

vvdb-architecture commented 6 months ago

… in order to avoid the use of the PeriodicBatchingSink type that became sealed in versions of the `Serilog.Sinks.PeriodicBatching package later than 2.3.1.

This is a simple attempt to solve https://github.com/serilog-contrib/serilog-sinks-splunk/issues/169.

VictorioBerra commented 6 months ago

@vvdb-architecture Did you see there was already a PR for this? https://github.com/serilog-contrib/serilog-sinks-splunk/pull/168

Which do you prefer?

VictorioBerra commented 6 months ago

@vvdb-architecture Upon reading both, #168 updates the package versions, XML comments, and docker container versions. Could you close this one and we can try and get the other one pushed through somehow? This project does not have a dedicated maintainer at this time so we will have to figure something out.

vvdb-architecture commented 6 months ago

Closed by popular request #168 is more complete.