serilog-contrib / serilog-sinks-splunk

A Serilog sink that writes to Splunk
https://splunk.com
Apache License 2.0
46 stars 47 forks source link

Set up GitHub Actions #174

Closed nblumhardt closed 6 months ago

nblumhardt commented 6 months ago

This setup is via https://github.com/serilog-tracing/serilog-tracing.

I've gone for the quickest thing I could pull together, happy to tweak it here, or just merge/debug and leave it in your hands, @EEParker and @VictorioBerra :-)

Closes #173

EEParker commented 6 months ago

This looks like a good start, I would also like to add something to generate release notes for tags (release versions) and use the tag name as the version number to publish to nuget.

For example:

ci-release.yml

on:
  push:
    tags:
    - '*'

# [ include content from dev build ci] [...]
    steps:
   # [...]
   - name: Create Release
      uses: ncipollo/release-action@v1
      with: 
        artifacts: "*.nupkg"
        generateReleaseNotes: true
nblumhardt commented 6 months ago

Hopefully what's there is enough to get the ball rolling now; generating release notes and using tags would be a nice improvement, unfortunately I don't have the time to roll that into this PR, but happy helping anywhere I'm needed down the line.

EEParker commented 6 months ago

Looks good, thanks for the help.

VictorioBerra commented 6 months ago

What do we think about this @EEParker? When can we test our first NuGet deployment with Actions?

EEParker commented 6 months ago

I have one small change I want to make to this, but it can be done after the merge. I want to add a separate ci for automatic releases on tags. Dev/main/master can use the branch name and build number for the pre release version.

EEParker commented 6 months ago

@VictorioBerra I have added my changes to this PR. I was able to test Build.ps1 successfully locally, but we will have to run it here to see if the actions work.

I am ready for this to be merged. It should generate a prerelease 4.0.0 build.

EEParker commented 6 months ago

image

nblumhardt commented 6 months ago

Good luck with the project, @EEParker and @VictorioBerra. I'll tune out regular traffic on this repo, but please @ me anytime I can help :-)

EEParker commented 6 months ago

Thank you for your assistance!

VictorioBerra commented 6 months ago

Thank you!!