search

serilog-contrib / serilog-sinks-splunk

A Serilog sink that writes to Splunk
https://splunk.com
Apache License 2.0
46 stars 47 forks source link

Fix for missing TraceId and SpanId #196

Closed EEParker closed 7 months ago

EEParker commented 7 months ago

This PR adds a reproduction for #195 to the sample project.

EEParker commented 7 months ago

image Sample app reproduction and fix success.

github-actions[bot] commented 7 months ago

Code Coverage

Package Line Rate Branch Rate Health
Serilog.Sinks.Splunk.TCP 65% 43% ➖
Serilog.Sinks.Splunk 19% 19% ❌
Serilog.Sinks.Splunk 49% 63% ❌
Summary 42% (334 / 818) 44% (86 / 208) ❌
EEParker commented 7 months ago

Implement changes from https://github.com/serilog/serilog/pull/1955

VictorioBerra commented 7 months ago

@EEParker overwriting the current TraceIdentifier won't break anything right? Not an expert on that but that's for the entire request right? Would that affect any other middleware?

EEParker commented 7 months ago

Are you referring to the sample app? That is to add a fake traceid since it isn't running aspnetcore. The actual sink is just adding the missing fields from the upstream generic json sink.

VictorioBerra commented 7 months ago

I was looking at this on my phone and didn't see what app the file was in, looks good!