search

serilog-contrib / serilog-sinks-splunk

A Serilog sink that writes to Splunk
https://splunk.com
Apache License 2.0
46 stars 47 forks source link

System.Net.Http NuGet Reference in .NET Framework 4.7.1 #77

Closed Blackbaud-JeffDye closed 6 years ago

Blackbaud-JeffDye commented 6 years ago

Hey y'all, using this sink in a full .net framework app (even 4.7.1) seems to pull in the System.Net.Http nuget package (v4.3.2) which can cause all kinds of reference errors and assembly binding issues, along with dependencies on a few System.Security.* packages too. In this case, I think we'd rather use the actual Framework System.Net.Http.

This is similar to this issue in another sink: https://github.com/serilog/serilog-sinks-seq/issues/83 Changeset which resolved that issue: https://github.com/serilog/serilog-sinks-seq/pull/85/files

Would it be possible to remove that package for Framework specifically for 4.7+?

merbla commented 6 years ago

@Blackbaud-JeffDye sounds reasonable, just on leave for a few weeks. Feel free to PR if you need earlier.

jeffbdye commented 6 years ago

Sounds good @merbla, I'll give it a try.