serilog-contrib / serilog-sinks-splunk

A Serilog sink that writes to Splunk
https://splunk.com
Apache License 2.0
46 stars 47 forks source link

Split sinks into separate packages/repositories #88

Closed merbla closed 6 years ago

merbla commented 6 years ago

Currently the Splunk package caters for three sinks:

This however introduces issues such as limitations relating to signing dlls (see: #76) & .NetCore support across all sinks (see: #65). In addition, there is not a clear indication of usage of each sink.

To allow the related sinks to evolve independently, this is a proposal to split the sinks into isolated packages.

Notes/Considerations:

Option 1

Status Quo, all three sinks packaged together and we deal with the issues mentioned

Option 2

Split sinks and packages into separate repos/packages

Option 3

Introduce meta-packages

Thoughts? Other ideas?

nblumhardt commented 6 years ago

At least from a project/repository layout point of view, I can see option 3 being easier to fit with the way things are organized today: we could just create two new repos for the .Tcp and .Udp sinks, and all would be business-as-usual. Not a consumer though, so not sure what my opinion is worth on this one :-D

merbla commented 6 years ago

Addressed in #89