search

serilog-contrib / serilog-ui

Simple Serilog log viewer UI for several sinks.
MIT License
226 stars 42 forks source link

feat(provider): add SQLite sink support #124

Closed techgarage-ir closed 1 month ago

techgarage-ir commented 3 months ago

Hi @followynne I've made Sqlite support, some tests are failing because no TestContainers found for Sqlite so changed tests to use InMemory database instead but base classes use TestContainer. Please take a look on it.

mo-esmp commented 3 months ago

@techgarage-ir Thanks for the PR. We will review it soon.

followynne commented 3 months ago

Hi @techgarage-ir

thanks a lot, really appreciate it!!

I'll try do understand how to make tests work with the TestContainer package, I'd prefer it as it would give us a better integration suite.

Just to let you know, I'll check the PR after we complete v3 development - this will require a small update to your implementation to align to the modified API.

Just to know, do you prefer

Thanks a bunch 🥇

techgarage-ir commented 3 months ago

Hi again

So good, I'm looking for v3.

That's not matter, do what's your usual in project and I'll make required changes asap.

followynne commented 3 months ago

@techgarage-ir

as an update, I started working on a branch towards yours, to align with v3 and fix anything I find 😄

techgarage-ir commented 3 months ago

That's great, I've used v2 with Sqlite on a project and found just one bug that's log time is in incorrect timezone, but I guess that's being fixed in v3 due to this note.

mo-esmp commented 1 month ago

@techgarage-ir could you please update SqliteDataProvider based on the latest changes? Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

followynne commented 1 month ago

FYI: test update WIP.

techgarage-ir commented 1 month ago

@techgarage-ir could you please update SqliteDataProvider based on the latest changes? Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

Yes, I'll check it ASAP.

followynne commented 1 month ago

@techgarage-ir could you please update SqliteDataProvider based on the latest changes? Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

Yes, I'll check it ASAP.

Hi @techgarage-ir ,

Fyi, I already pushed the updated code to your repo and was working on fixing tests. Please give it a look and a test if you have time,especially for the new sort feature, thanks!

techgarage-ir commented 1 month ago

@techgarage-ir could you please update SqliteDataProvider based on the latest changes? Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

Yes, I'll check it ASAP.

Hi @techgarage-ir ,

Fyi, I already pushed the updated code to your repo and was working on fixing tests. Please give it a look and a test if you have time,especially for the new sort feature, thanks! Hi

That's fine, I'm looking at it and will use it on some test projects to get more details.

followynne commented 1 month ago

That's awesome, thanks! I'll try to complete the tests this weekend and notifiy you for a final greenlight 👍

followynne commented 1 month ago

Hi @techgarage-ir

code updated to final version, I fixed issues with the Datetime querying (since field is a text, it wasn't working correctly), feel free to give it a try - if you're okay with it, we can close the PR!

@mo-esmp I added you as a reviewer, to let you give the code a double check since you did the latest sql-refactoring 😄 on my side we're fine and we close the PR 👍

mo-esmp commented 1 month ago

Thanks for the contribution, @techgarage-ir. @followynne please publish the NuGet package and add me as an owner.