Add trimming to rendered message and message template

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL

Apache License 2.0

278 stars 148 forks source link

Add trimming to rendered message and message template #394

Closed andypeeters closed 2 years ago

andypeeters commented 2 years ago

Add separate functions to trim the rendered message and message template text when the corresponding database fields are too small for saving the data, implementing #209.
Add unit tests to check the trimming effect when called.
Update README.md with explanation about the trimming effect.

andypeeters commented 2 years ago

@ckadluba My apologies to the change of the quote in README.md file. Apperently JetBrains Rider didn't like the original quote and replaced it without me really knowing. I changed that to a straight single quote. That's OK for you?

andypeeters commented 2 years ago

There was a nagging feeling that the README was not correct, so I checked it again. I think that a forward tick was missing and I believe the text is properly rendered now. At the same time I switched around the maximum length comparisons.

ckadluba commented 2 years ago

@studiopasokon thank you for the contribution. I think it looks very good. Only two more additions in the README I would suggest, then it can be merged from my point of view.

andypeeters commented 2 years ago

Here you go. I hope that I fixed the right things. If something is still not correct, just let me know.