serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
278 stars 148 forks source link

Microsoft.Azure.Services.AppAuthentication is deprecated #400

Closed dandros closed 2 years ago

dandros commented 2 years ago

Serilog.Sinks.MSSqlServer is using Microsoft.Azure.Services.AppAuthentication which is deprecated by now.

MS suggests to switch to Azure.Identity library.

Is it possible for you to migrate this dependency ?

ckadluba commented 2 years ago

Hi @dandros!

Thanks for the input. As far as I could find in the Microsoft documentation AppAuthentication library is not yet deprecated but will eventually be at some point.

I will take a look at migrating this. Although cannot promise when I will have time to do it. In the meantime a PR to help us with migration to Azure.Identity is always welcome. :)

ckadluba commented 2 years ago

Fixed with PR #424.