Removing deprecated Microsoft.Azure.Services.AppAuthentication nuget package and replacing it by Azure.Identity

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL

Apache License 2.0

283 stars 148 forks source link

Closed azerios closed 2 years ago

azerios commented 2 years ago

Hello,

The IT security team of my company will not go live if the Microsoft.Azure.Services.AppAuthentication nuget package is used as reference.

The goal of this PR is to replace it by Azure.Identity without causing any regression.

If this fix isn't enough, feel free to do it on another branch and closed mine.

Again, without this critical security change, it's one year lost for my team.

This is link to #400

Regards

azerios commented 2 years ago

@ckadluba @studiopasokon Is it possible to review this PR ?

ckadluba commented 2 years ago

Again, please create a new PR for dev as this is our target branch for contributions.

Thank you!