search

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
283 stars 148 forks source link

Microsoft.Azure.Services.AppAuthentication still in use #427

Closed azerios closed 2 years ago

azerios commented 2 years ago

Dear,

A reference to Microsoft.Azure.Services.AppAuthentication is present here / https://github.com/serilog-mssql/serilog-sinks-mssqlserver/blob/main/src/Serilog.Sinks.MSSqlServer/Serilog.Sinks.MSSqlServer.csproj

Is it possible to find a way to remove it as my pull request wasn't merge ?

Regards

ckadluba commented 2 years ago

This is because we have fixed the issue in the dev branch and not updated main branch yet. We will update main when we make the next regular release (which is planned as soon as we are finished with the .NET 6 upgrade).

As we removed the AppAuthentication dependency on the dev branch, a preview/dev release was built and pushed to nuget.org.