search

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
283 stars 148 forks source link

Update deps cleanup #428

Closed ckadluba closed 2 years ago

ckadluba commented 2 years ago

Breaking change: "Encrypt=False" must now be explicitly set in connection string if no encryption should be used. Otherwise an SqlException will occurr (SqlClient >=4.0.0).

ckadluba commented 2 years ago

Looks good, just some readme fixes.

Were you looking to remove more obsolete overloads in 6.0?

Thank you taking the time to review jono. It really helps a lot. :)

Yes, i thought about removing the obsolete init methods with 6.0.0. But since we already have this breaking change from SqlClient (which will for sure cause trouble for some users), I did not want to make their life harder by making additional breaking changes in 6.0.0. The obsolete methods are only a thin layer and do really not create any maintenance effort. I think they can stay for some more releases. :)