search

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
283 stars 148 forks source link

Automatic DB creation #466

Closed ckadluba closed 1 year ago

ckadluba commented 1 year ago
ckadluba commented 1 year ago

@jonorossi No worries. It was not urgent and there were quite some code changes to review in this PR.

I agree. This feature is not something I would typically use in production either. For me it is more something that helps in training or technical research scenarios where someone would quickly create a sample app with the sink and test it locally on a dev machine with a local SQL Server Express without having to create the DB as an extra step. But according to issue #360, there seems to be some real world demand for it, it was easy to add and is disabled by default.

Thanks a lot for the review! :)