serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
276 stars 147 forks source link

Fixed bug #515 #535

Closed vui611 closed 4 months ago

vui611 commented 4 months ago

When include 2 standard columns SpanId and TraceId, AuditTo() will throw an exception. The quick solution is adding ToString() for these columns in the function GetStandardColumnNameAndValue Fix #515

ckadluba commented 4 months ago

Thank you very much for the contribution! Can you please add at least one unit test to ensure the fix?

BR, Christian

vui611 commented 4 months ago

@ckadluba I have updated your exist test cases in the latest commit. Please have a look when you have a chance. Regards,