search

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
276 stars 147 forks source link

Update to Serilog v4, remove reference to Serilog.Sinks.PeriodicBatching #543

Open cremor opened 2 months ago

cremor commented 2 months ago

From the Serilog.Sinks.PeriodicBatching readme:

Serilog 4.x and later versions support batching natively. New projects should use Serilog's IBatchedLogEventSink and WriteTo.Sink(IBatchedLogEventSink), not this package which is now only maintained for compatibility reasons.

Therefore I suggest to release a new major version of this sink which directly uses IBatchedLogEventSink from Serilog and doesn't have a reference to Serilog.Sinks.PeriodicBatching any more.

ckadluba commented 4 days ago

The PR was merged. Thank you very much for the contribution @cancakar35!

@cremor, @cancakar35 and everyone interested: now the dev branch was updated with the contribution a dev packages was built and published on nuget.org. Could you please give this version a spin and let me know if it works fine or you see any new issues with it?

https://www.nuget.org/packages/Serilog.Sinks.MSSqlServer/7.0.0-dev-00087

If the feedback on the dev package is good, I will merge dev into main and produce a latest release 7.0.0.

cremor commented 3 days ago

I've ran a quick test in my solution and everything seems to work fine. Thanks!