serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
283 stars 148 forks source link

Release 6.7.1 #555

Closed ckadluba closed 2 months ago

ckadluba commented 2 months ago
github-advanced-security[bot] commented 2 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

cancakar35 commented 2 months ago

@ckadluba Why do we directly reference System.Private.Uri?

ckadluba commented 2 months ago

Hi @cancakar35!

Because there was a warning about a vulnerability when using dotnet nuget audit (see discussion here https://github.com/serilog-mssql/serilog-sinks-mssqlserver/issues/544#issuecomment-2320653299) and only referencing System.Private.Uri fixed it. As cremor noted, this might be a false positive caused by the SDK, but I didn't want to take the risk or let the sink have any warnings about vulnerabilities. Hopefully we can remove this again when MS fixes it the false positive or we upgrade the TFMs in the future.