search

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
283 stars 148 forks source link

Fixed issue #541 in README.md #577

Closed ckadluba closed 1 month ago

ckadluba commented 1 month ago

The Timestamp column is nullable by default but the README.md stated the opposite. This was fixed now.

cremor commented 1 month ago

Thanks, but why is the column actually nullable? How can there be a log line without a timestamp?

ckadluba commented 1 month ago

That's a good question. It can probably be answered only by the initial developers of this sink (which was not me :)). Now it is like it is and changing it would maybe break existing applications using the MSSQL sink. I agree with you, that a log entry without a timestamp is not quite useful.