search

serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
283 stars 148 forks source link

Deprecated transitive dependency on Microsoft.NETCore.Targets #580

Closed david-brink-talogy closed 1 month ago

david-brink-talogy commented 1 month ago

Please clearly describe what the SQL Sink is doing incorrectly:

Serilog.Sinks.MsSqlServer has a dependency on System.Private.Uri, which in turn depends on package Microsoft.NETCore.Targets, which is listed as deprecated on nuget.org.

An explicit reference to System.Private.Uri was added on #555 to address a vulnerability. The README for this package notes that "Internal implementation package not meant for direct consumption. Please do not reference directly". System.Private.Uri is only seen as a dependency when a project specifies runtime identifiers in its configuration.

Please clearly describe the expected behavior:

Serilog.Sinks.MsSqlServer does not depend on deprecated packages.

List the names and versions of all Serilog packages used in the project:

Target framework and operating system:

[x] .NET 6 [ ] .NET Framework 4.8 [ ] .NET Framework 4.7 [ ] .NET Framework 4.6 OS: Windows 10

ckadluba commented 1 month ago

@david-brink-talogy thank you very much for investigating and fixing this. It is highly appreciated. :)

After the PR was merged, the dev release 7.0.2-dev-00104 was published on nuget.org. We are thankful to anyone who could give it a spin and tell us of any problems.