Closed gkinsman closed 9 months ago
Thanks for sending this; will have a dig in properly as soon as I have a chance (the last few months have been a bit crazy, here :-))
Thanks for sending this; will have a dig in properly as soon as I have a chance (the last few months have been a bit crazy, here :-))
No worries Nick! Hope everything's well š
@gkinsman snowed :-D but digging out hehe š
This PR is a WIP proposal to fix #47. There's still a few unanswered questions below as I'm not sure this is 100% the right direction :).
It introduces a new method to
IDiagnosticContext
that allows users to begin a newDiagnosticContextScope
that collects properties viaIDiagnosticContext
:Open Questions
There's still a number of areas that haven't been fully thought through on the interface method:
RequestLoggingMiddleware
)?IDiagnosticContext
isn't the right place forBegin
, and that maybe it belongs on some other thing that should be injected to keep IDC clean. Putting it onILogger
might work, but then you'd need to pass in anIDiagnosticContext
.Sample Usage
Which produces this event: