Open fuzolan opened 6 years ago
I think we might look into enabling rollOnFileSizeLimit: true
in this package :+1:
I think we might look into enabling
rollOnFileSizeLimit: true
in this package 👍
Hi @nblumhardt
This is exactly what I need. I am new to Serilog and I have read source code of this repo but cannot find (or don't know) how to put rollOnFileSizeLimit: true
. Could you show me, where it should be put? Therefore, I can make my own fork and add that feature. This discussion is old and it seems that this feature request will not be implemented soon.
Thanks
Hi @firstyuyu - it should be here I believe:
HTH!
Hi @firstyuyu - it should be here I believe:
HTH!
Hi @nblumhardt ,
Thanks. For anyone who face this issue, I have forked this repo and add two optional parameters on AddFile
extension method.
rollOnFileSizeLimit
: the default value is true
rollingInterval
: the default value is RollingInterval.Day
Is there an update on officially implementing this in the main repo?
@MikeRavenelle none at this point - a PR would be welcome if anyone is interested in taking a closer look.
@nblumhardt Hello, I made pr about it, can you review please? https://github.com/serilog/serilog-extensions-logging-file/pull/60
My expectation is that a new file should be written if the size limit reaches the maximum. Instead log-messages are lost.
I use the component in a asp core 2 project. Configuration is in appsettings.json.