search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
313 stars 100 forks source link

Split out ASP.NET Core hosting dependency from 2.1-dev #102

Closed nblumhardt closed 7 years ago

nblumhardt commented 7 years ago

Although we're targeting the hosting infrastructure with UseSerilog() in ASP.NET Core 2, other environments that use Serilog + MEL may not want this dependency (e.g. Orleans).

Following the naming pattern used by ASP.NET Core 2, I'm working on new Serilog.AspNetCore and Serilog.AspNetCore.All packages here: https://github.com/nblumhardt/serilog-aspnetcore.

Once that's ready to move over into the Serilog org, we can remove the UseSerilog() extension and web sample from this repository.

merbla commented 7 years ago

Is it worth attempting to keep those meta packages in this repo and use a separate build?

nblumhardt commented 7 years ago

Thanks for the suggestion. I thought about it, but the effort maintaining a different build didn't seem worth it. Have had my head down, sorry I missed your comment before charging ahead :-)

https://github.com/serilog/serilog-aspnetcore

(I've left out the All package for now, just needs more fiddling around.)

Tried getting the essentials into the README over there - any thoughts?

merbla commented 7 years ago

Looks good, do we ditch the sample from this repo in favour of that one?

nblumhardt commented 7 years ago

:+1: yes, going to strip this repo back a bit, PR incoming :-)