search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
309 stars 99 forks source link

I have changed the registration of the LoggerProvider with using a factory for creating an instance. #113

Closed Sensarg22 closed 6 years ago

Sensarg22 commented 6 years ago

It was necessary because the DI container ignores a registered singleton with an instance during disposing.

Sensarg22 commented 6 years ago

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/dependency-injection#disposing-of-services

nblumhardt commented 6 years ago

Nice catch - thank you!

kmcclellan commented 5 years ago

Can we expect to see this merged into master at some point? A Nuget release would be nice.