search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
309 stars 99 forks source link

Upgraded Microsoft.Extensions.Logging NuGet packages to 2.0.0 #131

Closed DigiBanks99 closed 5 years ago

DigiBanks99 commented 5 years ago

With regards to Issue: https://github.com/serilog/serilog-extensions-logging/issues/115

I have bumped the versions of the Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions libraries to 2.0.0 for .net standard and .net framework 4.61. I've also bumped Serilog to 2.8.0.

nblumhardt commented 5 years ago

Thanks @DigiBanks99 !

Re-reading, I think the intent of #115 is to use a single dependency version across all target frameworks; perhaps we should make the break in a new major version, and just drop support (from the current version of the package) for TFMs that Microsoft.Extensions.Logging 2.0 doesn't reach? 🤔

DigiBanks99 commented 5 years ago

@nblumhardt Hmmm... Yeah, That makes more sense. I'll do it that way then.

DigiBanks99 commented 5 years ago

The Microsoft.Extensions.Logging.Abstractions versions seems to be very inconsistent across the various Serilog projects, as seen here, so I'm not really sure if I should bump it to 2.1.0 at the very least and maybe update the remaining repositories as well?

nblumhardt commented 5 years ago

@DigiBanks99 I think aiming for consistency will only make a temporary improvement, since the various projects move forwards at their own cadence - I think making the changes here, first, is a good start :-) :+1:

nblumhardt commented 5 years ago

I've had another look at this and think we should release it as a 3.0, along with (I guess) a dependency on the 3.0 MEL packages. Looking at v2 of MEL, there's no separate .NET Framework target anymore, so no point maintaining that here, either.

I've just pushed a release from dev -> master, if that's all successful I think we can get this onto dev and start shaping up the v3 :+1: