search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
313 stars 100 forks source link

Change namespace for SerilogLoggingBuilderExtensions.AddSerilog #134

Closed tai-yi closed 5 years ago

tai-yi commented 5 years ago

Please change SerilogLoggingBuilderExtensions's namespace to Microsoft.Extensions.Logging. I just want add Serilog.

services.AddLogging(c =>
            {
                c.AddConsole();
                c.AddSerilog();
            });

Got too many error.

'ILogger' is an ambiguous reference between 'Microsoft.Extensions.Logging.ILogger' and 'Serilog.ILogge'
nblumhardt commented 5 years ago

Thanks for the feedback 👍

At this stage, a namespace change would be tricky, breaking existing binaries compiled against this package. I don't think it's a change we can make in the near future, but worth us keeping in mind.

Thanks again!