search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
309 stars 99 forks source link

Make the level mapping routines public #141

Closed nblumhardt closed 5 years ago

nblumhardt commented 5 years ago

If there's any library where this belongs, I guess it's here. Resolves #81.

No tests, as they'd be pretty much an exact copy of the already-declarative code.

nblumhardt commented 5 years ago

Any thoughts on this, @serilog/reviewers-core ?

tsimbalar commented 5 years ago

LGTM ! 👍

I see it as extremely tempting to make them extension methods , but I suppose that YAGNI tells me that NO 🤷‍♂

(and if we were to do it, should the namespace be any different ? 🤔 )

nblumhardt commented 5 years ago

I thought about this, but came out on the side of restraint since usage will be very, very infrequent (as far as I can tell). Extension methods do bring all kinds of namespace pollution concerns into the picture :-) .. Might just side-step that and :shipit:

nblumhardt commented 5 years ago

Thanks for the review, BTW! :-)

xrkolovos commented 5 years ago

when will this feature be released?

nblumhardt commented 5 years ago

@xrkolovos thanks for the nudge; no plan yet, but https://github.com/serilog/serilog-extensions-logging/pull/145 is the PR to watch.