search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
309 stars 99 forks source link

`LoggerProviderCollection` should not be `IDisposable` #143

Closed nblumhardt closed 4 years ago

nblumhardt commented 5 years ago

The providers within it are generally owned by the composition system, e.g. https://github.com/serilog/serilog-extensions-logging/blob/dev/samples/Sample/Program.cs#L31 - so it has no business disposing them :-)

nblumhardt commented 5 years ago

Second thoughts, this needs a careful look, providers may not be flushed if they're not otherwise disposed by the DI container.

SimonCropp commented 4 years ago

given v3 has been released. is this included in that milestone? and should the milestone be closed

nblumhardt commented 4 years ago

Thanks 👍