search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
307 stars 97 forks source link

Added notes about Log Scope usage to README #182

Closed Rabadash8820 closed 3 years ago

Rabadash8820 commented 3 years ago

The ability to pass any IEnumerable<KeyValuePair<string, object>> to ILogger.BeginScope is an extremely useful feature, but unfortunately it doesn't seem to be officially documented anywhere. I only discovered it while digging through this repo's source code! I assume this repo is the correct location for this information, as it only applies when one is using both Serilog and the Microsoft.Extensions.Logging library, but I could see where it might be better off in the Serilog wiki. Looking forward to your feedback!

Rabadash8820 commented 3 years ago

@sungam3r So is there any interest in merging this PR or nah?

skomis-mm commented 3 years ago

Looks good 👍