search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
307 stars 97 forks source link

Consider publishing for net461 like Microsoft.Extensions.Logging does #196

Closed Nefarion closed 1 year ago

Nefarion commented 2 years ago

Microsoft.Extensions.Logging 5.* targets net461 as well.

I had to fork the repo and republish with net461, because with the current version i get a MissingMethodException on AddSerilog().

Greetings from Vienna!

nblumhardt commented 2 years ago

Thanks for the note. IIRC, 4.6.1 has some deployment issues for .NET Standard that don't occur in 4.6.2 - will need to go back over some history to figure out how we ended up at the current targets... :-) (and greetings from Brisbane!)

Nefarion commented 2 years ago

I just found this comment (https://github.com/serilog/serilog-extensions-logging/pull/191#issuecomment-865435500), i had the same problem (thus i made this issue) and publishing for net461 fixed it.

SimonCropp commented 2 years ago

givven support for net461 expires next month, it is trivial to update to 462 of higher, i dont think this is worth the effort

sungam3r commented 1 year ago

According to

These must match the Dependencies tab in https://www.nuget.org/packages/microsoft.extensions.logging at the target version.

note from csproj for v7 I think this issue can be closed as not planned.