search

serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging
Apache License 2.0
313 stars 100 forks source link

Adding netstandard 2.0 logging abstraction support #83

Closed gertjvr closed 7 years ago

gertjvr commented 7 years ago

This is ready to be reviewed!

nblumhardt commented 7 years ago

Awesome, thanks Gert 👍

gertjvr commented 7 years ago

First time working with multi targeting csproj any tips would be helpful.

nblumhardt commented 7 years ago

May not have a chance to look at it today, but we've done a lot of multi-targeting in various Serilog projects, so if you hit any blockers, posting here should yield some tips :-)

gertjvr commented 7 years ago

Will have to comeback to it later, it builds locally for me, not sure why appveyor is not finding the preview packages.

nblumhardt commented 7 years ago

Thanks a million for the PR, Gert :-)

I'm still wrapping my head around some of the targeting requirements (the new logging packages still target netstandard1.1, for instance, so we don't strictly need to target netstandard2.0 AFAICT), but this will definitely get us started and seems the lowest-churn way forward 👍

nblumhardt commented 7 years ago

We're in business :-) Thanks @gertjvr.

@pakrym @davidfowl @BrennanConroy if anyone gets a change to kick the tyres/sanity check us, this package is out on NuGet as https://www.nuget.org/packages/Serilog.Extensions.Logging/2.0.0-dev-10164. Cheers!

gertjvr commented 7 years ago

I am updating the sample project, will push as soon as I get it to build properly

gertjvr commented 7 years ago

Will have a look later today

gertjvr commented 7 years ago

Maybe raise an issue so we can track it.