search

serilog / serilog-settings-configuration

A Serilog configuration provider that reads from Microsoft.Extensions.Configuration
Apache License 2.0
456 stars 129 forks source link

Fix ReSharper/Rider inspection warnings #312

Closed 0xced closed 2 years ago

0xced commented 2 years ago

The serilog-settings-configuration.sln.DotSettings file defines many custom inspection severities as error rendering the solution with many red squiggly lines when opened in Rider or in Visual Studio with ReSharper.

nblumhardt commented 2 years ago

Thanks for all of this @0xced ! 👍 👍

Looks like a test failure:

Failed Serilog.Settings.Configuration.Tests.DllScanningAssemblyFinderTests.ShouldProbeCurrentDirectory [5 ms]
  Error Message:
   System.IO.DirectoryNotFoundException : Could not find a part of the path 'C:\projects\serilog-settings-configuration\test\Serilog.Settings.Configuration.Tests\bin\Release\net50\bin1'.
  Stack Trace:
     at System.IO.FileSystem.GetFindData(String fullPath, WIN32_FIND_DATA& findData)
   at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
   at System.IO.Directory.Delete(String path, Boolean recursive)
   at Serilog.Settings.Configuration.Tests.DllScanningAssemblyFinderTests.Dispose() in C:\projects\serilog-settings-configuration\test\Serilog.Settings.Configuration.Tests\DllScanningAssemblyFinderTests.cs:line 18
   at ReflectionAbstractionExtensions.DisposeTestClass(ITest test, Object testClass, IMessageBus messageBus, ExecutionTimer timer, CancellationTokenSource cancellationTokenSource)
Failed!  - Failed:     1, Passed:   116, Skipped:     0, Total:   117, Duration: 592 ms -
0xced commented 2 years ago

Oops. I fixed the issue, rebased on the dev branch and force pushed. Everything is ✅ now.

skomis-mm commented 2 years ago

Thanks, @0xced 👍