search

serilog / serilog-settings-configuration

A Serilog configuration provider that reads from Microsoft.Extensions.Configuration
Apache License 2.0
446 stars 129 forks source link

Drop support for .NET Framework 4.5.1 #351

Closed 0xced closed 1 year ago

0xced commented 1 year ago

Support for .NET Framework 4, 4.5, and 4.5.1 ended on January 12, 2016, that was 7 years ago!

Also bump Microsoft.Extensions.Configuration.Binder and Microsoft.Extensions.DependencyModel to version 6.0.0 since version 2.0.0 and 3.0.0 respectively have been deprecated as part of the .NET Package Deprecation effort.

Finally, this change allows to remove all conditional compilation.

Note that removing a target framework is a breaking change so it will require a major version bump, i.e. 4.0.0.

HexHunter97 commented 1 year ago

Serilog itself has also dropped support for anything below .Net Framework 4.6.1 and .Net Standard 2.0 some time ago, so there is no expectation from that angle to keep supporting 4.5.1 either.

glen-84 commented 1 year ago

4.6.1 is also EOL, why support it?

Edit: I suppose bc the main project still supports it.

andrewboudreau commented 1 year ago

Will this go into a 3.5 pre-release or is it too late for that?

nblumhardt commented 1 year ago

We should look at releasing this as 4.0.0 in the very near future 👍

andrewboudreau commented 1 year ago

I actually built this branch out and getting the same warning with 6.0.0 that I was with 3.0.0. I had to go to 7. I assume there is some nugget switch for >= on DependencyModel and Configuration Binder

glen-84 commented 1 year ago

@0xced Any reason not to update Microsoft.Extensions.* to 7.0.0?

glen-84 commented 1 year ago

According to this, the EOL of these packages might be bound to the corresponding framework, so perhaps 6.0.0 is best.

Having said that, we still need a solution for https://github.com/serilog/serilog-settings-configuration/issues/331#issuecomment-1309860435.

Does that lead us back to #339?

andrewboudreau commented 1 year ago

@glen-84 end of the day the issues ends up being build images available on appveyor for net7?

andrewboudreau commented 1 year ago

Additionally, I'm running the dependency with 3.0 on other 7.0 by ignoring the warning. Things seem to to be fine. So, 6.0 probably fine?

glen-84 commented 1 year ago

Ignoring the warning is not a solution.

glen-84 commented 1 year ago

We should look at releasing this as 4.0.0 in the very near future 👍

@nblumhardt How near is very near? 🙂