search

serilog / serilog-settings-configuration

A Serilog configuration provider that reads from Microsoft.Extensions.Configuration
Apache License 2.0
444 stars 129 forks source link

.NET 8 RC2 #400

Closed nblumhardt closed 9 months ago

nblumhardt commented 10 months ago

Working my way through these in preparation for RTM in a couple of weeks.

I tried to keep this one as additive/nondestructive as possible, given all the quirks this project has to deal with across the supported TFMs :-)

0xced commented 10 months ago

In order to fix the tests that do not pass when running on .NET 8, <SelfContained>true</SelfContained> must be added to the TestApp.csproj file. This is because of a breaking change that was introduced in the .NET 8 SDK: Runtime-specific apps no longer self-contained. Especially this change:

If PublishSelfContained isn't explicitly set to false, the publish properties PublishSingleFile and PublishAot now imply SelfContained (if it's not specified) during dotnet publish only (that is, not for dotnet build or dotnet restore).

I had to read that sentence a few times to really grasp it!

nblumhardt commented 10 months ago

Thanks for checking this one out @0xced, I'll take a look and fix it up 👍