I dont think the reference to the System.Diagnostics.Debug package should be needed for any of the current target frameworks other than netstandard1.0, but the reference to the in-box version is currently disabled due to the DisableImplicitFrameworkReferences setting.
This change changes the project so that DisableImplicitFrameworkReferences is only set for netstandard1.0 so that the other targets pick up the inbox version. I'm not entirely sure what the situation is with DisableImplicitFrameworkReferences though as I'd thought the idea was to remove avoid dependency chains when referencing old netstandard versions from full .net, but it looks like some of the other Serilog libs set that for just netstandard and some set it for full framework builds as well?
Related: I don't think a reference to System.Diagnostics.Debug would be needed for a netstandard1.3 build either, not sure if there is a point in adding older versions at targets now though.
nblumhardt
commented
3 years ago
refs #6.
I dont think the reference to the
System.Diagnostics.Debugpackage should be needed for any of the current target frameworks other thannetstandard1.0, but the reference to the in-box version is currently disabled due to theDisableImplicitFrameworkReferencessetting.This change changes the project so that
DisableImplicitFrameworkReferencesis only set fornetstandard1.0so that the other targets pick up the inbox version. I'm not entirely sure what the situation is with DisableImplicitFrameworkReferences though as I'd thought the idea was to remove avoid dependency chains when referencing old netstandard versions from full .net, but it looks like some of the other Serilog libs set that for just netstandard and some set it for full framework builds as well?Related: I don't think a reference to System.Diagnostics.Debug would be needed for a netstandard1.3 build either, not sure if there is a point in adding older versions at targets now though.